giffer

commit 4bf1ba1c47ca9379e09f5bf98be8284c164ba2c0
parent 6f3a6ec2c0ad25d67bdcbe0d997faedc8d288f50
Author: Jack Mordaunt <jackmordaunt@gmail.com>
Date:   Fri,  9 Nov 2018 17:31:10 +1300

[~] Avoid buffering file since we aren't deleting them.

Diffstat:
M
ffmpeg.go
 | 
10
+---------

1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/ffmpeg.go b/ffmpeg.go
@@ -1,7 +1,6 @@
 package giffer
 
 import (
-	"bytes"
 	"fmt"
 	"image"
 	"io/ioutil"
@@ -95,14 +94,7 @@ func (f FFMpeg) Extract(video string, start, end, fps float64) ([]image.Image, e
 		if info.IsDir() {
 			return nil
 		}
-		// Note: Unsure if imaging buffers the file, so we buffer it
-		// 	here. This avoids invalidating the images when LeaveMess
-		// 	is false and the files are removed.
-		img, err := ioutil.ReadFile(path)
-		if err != nil {
-			return errors.Wrap(err, "opening frame")
-		}
-		frame, err := imaging.Decode(bytes.NewBuffer(img))
+		frame, err := imaging.Open(path)
 		if err != nil {
 			return errors.Wrap(err, "decoding frame")
 		}