kanban

commit 0eea421d5d4e56ddcf96ad722a6fea15fec6dadf
parent ce87b01267d9e6f07118773bf54f513780890253
Author: Jack Mordaunt <jackmordaunt@gmail.com>
Date:   Sat, 13 Feb 2021 18:02:36 +0800

fix: loop variable shadowing

Diffstat:
M
storage/storm/storm.go
 | 
12
+++---------

1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/storage/storm/storm.go b/storage/storm/storm.go
@@ -4,7 +4,6 @@ import (
 	"errors"
 	"fmt"
 	"log"
-	"strings"
 
 	"git.sr.ht/~jackmordaunt/kanban"
 	"git.sr.ht/~jackmordaunt/kanban/storage"
@@ -19,7 +18,7 @@ type Storer struct {
 	DB *storm.DB
 }
 
-// Schema is a database representation of a project.
+// Schema is a database representation of a kanban.Project.
 type Schema struct {
 	ID      string `storm:"id"`
 	Project kanban.Project
@@ -42,16 +41,10 @@ func Open(path string) (*Storer, error) {
 }
 
 func (s *Storer) Create(p kanban.Project) error {
-	return s.DB.Save(&Schema{
-		ID:      p.Name,
-		Project: p,
-	})
+	return s.DB.Save(&Schema{ID: p.Name, Project: p})
 }
 
 func (s *Storer) Save(p *kanban.Project) error {
-	if len(strings.TrimSpace(p.Name)) == 0 {
-		return fmt.Errorf("project name required")
-	}
 	return s.DB.Update(&Schema{ID: p.Name, Project: *p})
 }
 
@@ -75,6 +68,7 @@ func (s *Storer) List() (list []*kanban.Project, err error) {
 		return nil, fmt.Errorf("loading projects: %v", err)
 	}
 	for _, p := range projects {
+		p := p
 		list = append(list, &p.Project)
 	}
 	return list, nil